On Tue, Nov 13, 2018 at 02:44:45PM +0000, Igor Russkikh wrote: > From: Dmitry Bezrukov <dmitry.bezrukov@xxxxxxxxxxxx> > > Add full hardware initialization sequence and link configuration logic Hi Igor I'm still not convinced the PHY driver should be embedded in the MAC driver, rather than using phylink. If i remember correctly, it was because the MAC is involved in determining if the link is up? That is nothing new. phylink expects this. The MAC driver should call phylink_mac_change() when the MACs SERDES goes up/down. Andrew