Re: [PATCH 2/3] spi: add FTDI MPSSE SPI controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Anatolij,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.20-rc1 next-20181105]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181106-090458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/include/uapi/asm/ptrace.h:6:0,
                    from arch/x86/include/asm/ptrace.h:7,
                    from arch/x86/include/asm/math_emu.h:5,
                    from arch/x86/include/asm/processor.h:12,
                    from arch/x86/include/asm/cpufeature.h:8,
                    from arch/x86/include/asm/thread_info.h:53,
                    from include/linux/thread_info.h:38,
                    from arch/x86/include/asm/preempt.h:7,
                    from include/linux/preempt.h:81,
                    from include/linux/spinlock.h:51,
                    from include/linux/seqlock.h:36,
                    from include/linux/time.h:6,
                    from include/linux/stat.h:19,
                    from include/linux/module.h:10,
                    from drivers/spi/spi-ftdi-mpsse.c:11:
>> arch/x86/include/uapi/asm/ptrace-abi.h:20:13: error: expected identifier before numeric constant
    #define CS  13
                ^
>> drivers/spi/spi-ftdi-mpsse.c:27:2: note: in expansion of macro 'CS'
     CS = BIT(3),
     ^~

vim +/CS +27 drivers/spi/spi-ftdi-mpsse.c

  > 11	#include <linux/module.h>
    12	#include <linux/gpio/consumer.h>
    13	#include <linux/gpio/machine.h>
    14	#include <linux/platform_device.h>
    15	#include <linux/printk.h>
    16	#include <linux/slab.h>
    17	#include <linux/spi/spi.h>
    18	#include <linux/types.h>
    19	#include <linux/sizes.h>
    20	#include <linux/usb.h>
    21	#include <linux/usb/ft232h-intf.h>
    22	
    23	enum gpiol {
    24		SK	= BIT(0),
    25		DO	= BIT(1),
    26		DI	= BIT(2),
  > 27		CS	= BIT(3),
    28	};
    29	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux