On Fri, 2 Nov 2018, Chengguang Xu wrote:
> dma_pool_destroy() can handle NULL pointer correctly, so there is
> no need to check NULL pointer before calling dma_pool_destroy().
>
> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx>
> ---
> drivers/usb/host/ohci-mem.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-mem.c b/drivers/usb/host/ohci-mem.c
> index b3da3f12e5b1..3965ac0341eb 100644
> --- a/drivers/usb/host/ohci-mem.c
> +++ b/drivers/usb/host/ohci-mem.c
> @@ -57,14 +57,10 @@ static int ohci_mem_init (struct ohci_hcd *ohci)
>
> static void ohci_mem_cleanup (struct ohci_hcd *ohci)
> {
> - if (ohci->td_cache) {
> - dma_pool_destroy (ohci->td_cache);
> - ohci->td_cache = NULL;
> - }
> - if (ohci->ed_cache) {
> - dma_pool_destroy (ohci->ed_cache);
> - ohci->ed_cache = NULL;
> - }
> + dma_pool_destroy(ohci->td_cache);
> + ohci->td_cache = NULL;
> + dma_pool_destroy(ohci->ed_cache);
> + ohci->ed_cache = NULL;
> }
>
> /*-------------------------------------------------------------------------*/
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
