On Wed, Apr 29, 2009 at 08:59:31PM +0200, Kay Sievers wrote: > On Wed, Apr 29, 2009 at 20:17, Mike Frysinger <vapier.adi@xxxxxxxxx> wrote: > > >>> looks like update-usbids.sh was forgotten from EXTRA_DIST in > >>> Makefile.am so the released tarball doesnt have the script ;( > > > np, i'll send patches for both > > Ah missed that, sorry. Sounds good if you add it to the tarball, but > please don't add it to "make install", as packages should not ship > scripts which change the installed package content, unless it's a > config file. Distros ship uppdate-usbids.sh, like they do the same for the pci ids file. And you can consider the usb.ids file a "config file" :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html