Hi Mathias: >-----Original Message----- >From: Mathias Nyman [mailto:mathias.nyman@xxxxxxxxxxxxxxx] >Sent: Tuesday, October 16, 2018 8:34 PM >To: Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; mathias.nyman@xxxxxxxxx; >gregkh@xxxxxxxxxxxxxxxxxxx >Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >Subject: Re: [PATCH] xhci: remove the unused sw_lpm_support > >On 16.10.2018 14:37, Zeng Tao wrote: >> It is introduced for the pre-0.96 xHC controllers, and the driver only >> support HW LPM for 1.0 and later controllers.It's not actually used >> now and is thought not to be used in the future any more, so just >remove it. >> >> Acked-by: Mathias Nyman <mathias.nyman@xxxxxxxxx> > >Please don't add my Acked-by to patches I haven't seen. > > From Documentation/process/submitting-patches.rst: > Thanks for pointing out the wrong tag, I meant to add suggested-by, ^_^ >"Acked-by: is not as formal as Signed-off-by:. It is a record that the acker >has at least reviewed the patch and has indicated acceptance." > >> Signed-off-by: Zeng Tao <prime.zeng@xxxxxxxxxxxxx> > >Otherwise the patch looks good, I'll queue it, and remove the extra >Acked-by > It's ok for me, thank you. Regards Zengtao