Hi Paul, Thank you for the patch. On Wednesday, 10 October 2018 05:48:58 EEST Paul Elder wrote: > V4L2_EVENT_PRIVATE_START is used in g_uvc.h but is defined in > videodev2.h, which is not included and causes a compiler warning: > > linux/usb/g_uvc.h:15:28: error: ‘V4L2_EVENT_PRIVATE_START’ undeclared here > (not in a function) #define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START + > 0) > > Include videodev2.h in g_uvc.h. > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> This is independent of the rest of the series so I've taken it in my tree already, with the subject line modified to use "usb: gadget: uvc:" as a prefix. > --- > include/uapi/linux/usb/g_uvc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/usb/g_uvc.h b/include/uapi/linux/usb/g_uvc.h > index 3c9ee3020cbb..6698c3263ae8 100644 > --- a/include/uapi/linux/usb/g_uvc.h > +++ b/include/uapi/linux/usb/g_uvc.h > @@ -11,6 +11,7 @@ > #include <linux/ioctl.h> > #include <linux/types.h> > #include <linux/usb/ch9.h> > +#include <linux/videodev2.h> > > #define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START + 0) > #define UVC_EVENT_CONNECT (V4L2_EVENT_PRIVATE_START + 0) -- Regards, Laurent Pinchart
