Re: [PATCH 01/23] xhci: Support xHCI host controllers and USB 3.0 devices.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 29, 2009 at 09:15:16AM -0700, Sarah Sharp wrote:
> On Tue, Apr 28, 2009 at 04:17:28PM -0700, Greg KH wrote:
> > On Mon, Apr 27, 2009 at 07:52:22PM -0700, Sarah Sharp wrote:
> > > This is the first of many patches to add support for USB 3.0 devices and
> > > the hardware that implements the eXtensible Host Controller Interface
> > > (xHCI) 0.95 specification.  This specification is not yet publicly
> > > available, but companies can receive a copy by becoming an xHCI
> > > Contributor (see http://www.intel.com/technology/usb/xhcispec.htm).
> > 
> > I've added these patches to my tree, so that others can play with them.
> > I imagine they will go through a few respins, which is fine, let me know
> > if you want me to replace individual ones, or add new ones.
> 
> Great!  I've actually already found a couple of bugs in the patchset
> since I ran it on new hardware yesterday.  Do you want me to respin the
> patches that those bugs are in, or add a new patch for the bug fixes?

New patches is probably best, unless you can say "replace patch X with
this patch", it might get messy otherwise.  You don't enable the driver
to be built until the last patch in the series, so it shouldn't be an
issue of bisecting.

> > Oh, you do know of the compiler warnings when building the xhci driver,
> > right?  :)
> 
> Yes, I did see that warning.  containerof is magic to me, so I just
> copied and modified the EHCI version of ehci_to_hcd().  The warning will
> be fixed shortly.

It's not a containerof warning, it is for dma_addr_t and using pointers
as integers in debugging statements (hint that is what %p is for...)

I have a patch pending to fix these warnings, give me a bit to finish it
up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux