On Tue, Oct 09, 2018 at 02:34:36PM +0000, Igor Russkikh wrote: > Hi Andrew, > > >> + if (ret < 0) > >> + goto out; > >> + > >> + memcpy(dev->net->dev_addr, buf, ETH_ALEN); > >> + memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); > > > > Is this really the permanent address? If i call aqc111_set_mac_addr() > > followed by aqc111_get_mac() i still get what is in the OTP EEPROM? > > Thats actually a confusion with function name here. > Think its better to name it aqc111_init_mac() since it gets called > only once on bind. Hi Igor Or aqc111_get_otp_mac()? Andrew
