Hi Andrew, >> >> + struct aqc111_data *aqc111_data = (struct aqc111_data *)dev->data[0]; > > Having to do this cast all the time is quiet ugly. It seems like some > other usb_net drivers use netdev_priv(). As I see most of usb usbnet based devices use the same theme with accessing private data via dev->data. netdev_priv() is used to store struct usbnet itself. >> + u8 dpa; /*direct PHY access*/ >> + struct aqc111_phy_options phy_ops; >> +} __packed; > > Why pack this? Do you send it to the firmware? Agreed, no. We have to pack phy_ops and wol_config only. Regards, Igor
