On 09/25/2018 10:19 AM, Woojung.Huh@xxxxxxxxxxxxx wrote: > Hi Florian, > >> @@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev, >> if (wol->wolopts & WAKE_ARP) >> pdata->wol |= WAKE_ARP; >> >> + if (pdata->wol == 0) >> + return -EINVAL; >> + > It will make function return when disabling WOL. Huh, yes, good point. > Is there other place handling this scenario? How do you mean? > >> device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts); >> >> phy_ethtool_set_wol(netdev->phydev, wol); > > > Thanks. > Woojung > -- Florian
