Re: [PATCH 0/4] usb: gadget: uvc: Fix endianness and sign issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 18, 2018 at 03:32:43PM +0300, Laurent Pinchart wrote:
> Hello,
> 
> This series addresses endianness and sign issues in the configfs support
> of the UVC gadget function driver.
> 
> The first patch starts by fixing the endianness of various UVC
> descriptors to match the USB little endian order. The second patch then
> fixed the UVC gadget function driver to handle endianness correctly when
> parsing configfs attributes.
> 
> The next patch goes on to simplify UVC configfs attribute macros, and
> the last patch finally fixes sign issues by using the correct format to
> print unsigned int values.

For the whole series:

Looks good to me.

Reviewed-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
Tested-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>

> Laurent Pinchart (4):
>   usb: video: Fix endianness mismatches in descriptor structures
>   usb: gadget: uvc: configfs: Fix operation on big endian platforms
>   usb: gadget: uvc: configfs: Simplify attributes macros
>   usb: gadget: uvc: configfs: Use %u to print unsigned int values
> 
>  drivers/usb/gadget/function/uvc_configfs.c | 241 +++++++++--------------
>  include/uapi/linux/usb/video.h             | 304 ++++++++++++++---------------
>  2 files changed, 249 insertions(+), 296 deletions(-)
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux