Re: [PATCH 08/23] Add route string to struct usb_device.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 28, 2009 at 11:59:49AM +0100, David Vrabel wrote:
> Oliver Neukum wrote:
> > Am Dienstag 28 April 2009 04:54:49 schrieb Sarah Sharp:
> >> + * @route: tree topology hex string for use with xHCI
> >>   * @state: device state: configured, not attached, etc.
> >>   * @speed: device speed: high/full/low (or error)
> >>   * @tt: Transaction Translator info; used with low/full speed dev, highspeed hub
> >> @@ -428,6 +429,7 @@ struct usb_tt;
> >>  struct usb_device {
> >>         int             devnum;
> >>         char            devpath [16];
> >> +       int             route;
> > 
> > Doesn't this have a specified length?
> 
> It's 20 bits.  Suggest a uint32_t here.

"u32" please, don't use userspace types in the kernel :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux