Re: [PATCH v3] usb: core: added uevent for over-current

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 20, 2018 at 10:58 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Sep 20, 2018 at 10:17:54AM -0700, Jon Flatley wrote:
> > After commit 1cbd53c8cd85 ("usb: core: introduce per-port over-current
> > counters") usb ports expose a sysfs value 'over_current_count'
> > to user space. This value on its own is not very useful as it requires
> > manual polling.
> >
> > As a solution, fire a udev event from the usb hub device that specifies
> > the values 'OVER_CURRENT_PORT' and 'OVER_CURRENT_COUNT' that indicate
> > the path of the usb port where the over-current event occurred and the
> > value of 'over_current_count' in sysfs. Additionally, call
> > sysfs_notify() so the sysfs value supports poll().
> >
> > Signed-off-by: Jon Flatley <jflat@xxxxxxxxxxxx>
> > ---
> >  Documentation/ABI/testing/sysfs-bus-usb |  9 ++++++-
> >  drivers/usb/core/hub.c                  | 36 +++++++++++++++++++++++++
> >  2 files changed, 44 insertions(+), 1 deletion(-)
>
> You should always put the "what changed in this version" below the ---
> line so that people know what happened.
>
> I am guess you just rebased this?  Any other change?
>
> thanks,
>
> greg k-h

Apologies, I'll make sure to do that in the future.

Yes, this is just a rebase onto v4.19-rc4, no other changes.
I checked to be sure this applies to usb-next without conflict.

Thanks,
Jon



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux