On Fri, Sep 14, 2018 at 03:01:22PM +0200, Greg KH wrote: > On Fri, Sep 14, 2018 at 03:33:29PM +0300, Mathias Nyman wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > The XUSB firmware header is in little endian byte order, so make the > > fields __le32 and __le16 instead of u32 and u16 to avoid warnings from > > sparse when the fields are used with the endian-aware __le32_to_cpu() > > and __le16_to_cpu() accessors, respectively. > > This isn't a "bug" in that no code is changed, so why is it needed for > 4.19-final? > > Shouldn't this be fine to merge in 4.20-rc1? Yeah, I don't think there's a need to rush this. It's only to fix a warning from sparse, but it shouldn't impact any code since the code itself already properly parses the firmware in little endian byte order. Thierry
Attachment:
signature.asc
Description: PGP signature
