* Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [180911 15:10]: > --- a/drivers/mfd/omap-usb-host.c > +++ b/drivers/mfd/omap-usb-host.c > @@ -855,31 +856,14 @@ static struct platform_driver usbhs_omap_driver = { > .pm = &usbhsomap_dev_pm_ops, > .of_match_table = usbhs_omap_dt_ids, > }, > + .probe = usbhs_omap_probe, > .remove = usbhs_omap_remove, > }; So I have this already along few other fixes in patch "[PATCH] mfd: omap-usb-host: Fix dts probe of children". > +module_platform_driver(usbhs_omap_driver); > + > MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@xxxxxx>"); > MODULE_AUTHOR("Roger Quadros <rogerq@xxxxxx>"); > MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); > MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI"); > - > -static int __init omap_usbhs_drvinit(void) > -{ > - return platform_driver_probe(&usbhs_omap_driver, usbhs_omap_probe); > -} > - > -/* > - * init before ehci and ohci drivers; > - * The usbhs core driver should be initialized much before > - * the omap ehci and ohci probe functions are called. > - * This usbhs core driver should be initialized after > - * usb tll driver > - */ > -fs_initcall_sync(omap_usbhs_drvinit); > - > -static void __exit omap_usbhs_drvexit(void) > -{ > - platform_driver_unregister(&usbhs_omap_driver); > -} > -module_exit(omap_usbhs_drvexit); Seems like part can then become part of your clean-up for v4.20 then? Regards, Tony