Re: [PATCH] usb: typec: Group all TCPCI/TCPM code together

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 07, 2018 at 06:35:12AM -0700, Guenter Roeck wrote:
> On 09/07/2018 05:56 AM, Heikki Krogerus wrote:
> > Moving all the drivers that depend on the Port Controller
> > Manager under a new a new directory drivers/usb/typec/tcpci/
> > and making Guenter Roeck as the designated reviewer of that
> > code.
> > 
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > ---
> > 
> > Hi guys,
> > 
> > This should be fairly trivial change. There is no functional effect.
> > Even menuconfig looks the same. The only interesting thing is that I'm
> > proposing that Guenter is marked as the reviewer/maintainer of all
> > TCPCI/TCPM drivers.
> > 
> > So Guenter, I guess the only question is that are you okay with this?
> > 
> 
> NP. I am not sure about the directory name, though. fusb and wcove don't
> really support tcpci; only rt1711h does. The common denominator is really
> the port manager (tcpm), not the port controller interface (tcpci).
> 
> As such, "typec port controller drivers" (without "interface") may be
> a bit more appropriate.

Makes sense.

> Not sure about the directory name, though. Maybe a simple "port" or
> "controller" would do ? Or anything else that doesn't look like the
> abbreviation for one of the supported protocols.

"port" maybe, but not controller. tps6598x.c is also a controller
driver, but it does not belong to that directory.

How about "phy"?

Does anybody have a proposal/vote what we should use?


Thanks,

-- 
heikki



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux