RE: [PATCH] usb: Change usb_of_get_companion_dev() place to usb/common

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg, Felipe,
(Add John's email to CC)

> From: Yoshihiro Shimoda, Sent: Tuesday, August 21, 2018 10:59 AM
> 
> Hi,
> 
> > From: Yoshihiro Shimoda, Sent: Monday, August 20, 2018 12:10 PM
> >
> > Since renesas_usb3 udc driver calls usb_of_get_companion_dev()
> > which is on usb/core/of.c, build error like below happens if we
> > disable CONFIG_USB because the usb/core/ needs CONFIG_USB:
> >
> > ERROR: "usb_of_get_companion_dev" [drivers/usb/gadget/udc/renesas_usb3.ko] undefined!
> >
> > According to the usb/gadget/Kconfig, "NOTE:  Gadget support
> > ** DOES NOT ** depend on host-side CONFIG_USB !!".
> > So, to fix the issue, this patch changes the usb_of_get_companion_dev()
> > place from usb/core/of.c to usb/common/common.c to be called by both
> > host and gadget.
> >
> > Reported-by: John Garry <john.garry@xxxxxxxxxx>
> > Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> On other email thread [1], Arnd said I have his Ack on this patch.
> So,
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> 
> [1]
> https://lkml.org/lkml/2018/8/20/216

I'm afraid but, would you apply this patch for linux v4.19?

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux