On Fri, Aug 31, 2018 at 01:22:21PM -0700, Ajay Gupta wrote: > + dev_info(dev, "Silicon id %2ph", data + CCGX_I2C_RAB_READ_SILICON_ID); > + dev_info(dev, "FW1 version %8ph\n", data + CCGX_I2C_RAB_FW1_VERSION); > + dev_info(dev, "FW2 version %8ph\n", data + CCGX_I2C_RAB_FW2_VERSION); Drivers should be totally quiet when initialized, unless something goes wrong. Please don't spam the kernel log with this type of stuff. You can use dev_dbg() if it helps with debugging the code, that might be a better idea here. Also, a pointer? Are you sure about that? That looks really odd... thanks, greg k-h
