Re: [hid:for-4.20/microsoft 2/2] hid-microsoft.c:undefined reference to `input_ff_create_memless'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 5 Sep 2018, kbuild test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/microsoft
> head:   73c5b254c36529c84c9d19e07905f7103bb32e79
> commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add rumble support for Xbox One S controller
> config: i386-alldefconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         git checkout 73c5b254c36529c84c9d19e07905f7103bb32e79
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/hid/hid-microsoft.o: In function `ms_probe':
> >> hid-microsoft.c:(.text+0x2d7): undefined reference to `input_ff_create_memless'

Now fixed in the branch as below. Thanks!


From: Jiri Kosina <jkosina@xxxxxxx>
Subject: [PATCH] HID: microsoft: the driver now neeed MEMLESS_FF
 infrastructure

Reflect that fact in Kconfig, the same we do for other such drivers.

Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 61e1953ff921..e5ec47705fa2 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -596,6 +596,7 @@ config HID_MICROSOFT
 	tristate "Microsoft non-fully HID-compliant devices"
 	depends on HID
 	default !EXPERT
+	select INPUT_FF_MEMLESS
 	---help---
 	Support for Microsoft devices that are not fully compliant with HID standard.
 
-- 
Jiri Kosina
SUSE Labs




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux