On Tue, Sep 04, 2018 at 10:44:41AM +0200, Oliver Neukum wrote:
> For those people who run with panic_on_warn a WARN() triggered
> from user space is a DOS. It is worth returning to dev_err()
I think this should be dev_warn() unless you want to bring back the
returning of errors on these conditions as well (i.e. as was the case
prior to 0cb54a3e47cb ("USB: debugging code shouldn't alter control
flow")).
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
> Fixes: 0cb54a3e47cb4baf0bc7463f0a64cfeae5e35697
This should be:
Fixes: 0cb54a3e47cb ("USB: debugging code shouldn't alter control flow")
> Reported-by: syzbot+843efa30c8821bd69f53@xxxxxxxxxxxxxxxxxxxxxxxxx
> ---
> drivers/usb/core/urb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
> index f51750bcd152..3fe65a774e6c 100644
> --- a/drivers/usb/core/urb.c
> +++ b/drivers/usb/core/urb.c
> @@ -475,7 +475,7 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
>
> /* Check that the pipe's type matches the endpoint's type */
> if (usb_urb_ep_type_check(urb))
> - dev_WARN(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n",
> + dev_err(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n",
> usb_pipetype(urb->pipe), pipetypes[xfertype]);
>
> /* Check against a simple/standard policy */
> @@ -499,7 +499,7 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
>
> /* warn if submitter gave bogus flags */
> if (allowed != urb->transfer_flags)
> - dev_WARN(&dev->dev, "BOGUS urb flags, %x --> %x\n",
> + dev_err(&dev->dev, "BOGUS urb flags, %x --> %x\n",
> urb->transfer_flags, allowed);
>
> /*
Johan
