On Fri, Aug 31, 2018 at 12:02 PM Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> wrote: > > Use IS_ERR() instead of IS_ERR_OR_NULL() because devm_of_phy_get_by_index() > never return NULL value; > But still need ignore the error of -ENODEV, for more information, please > refer to: > [0] https://lkml.org/lkml/2018/4/19/88 > [1] https://patchwork.kernel.org/patch/10160181/ > > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> > Reviewed-by: Johan Hovold <johan@xxxxxxxxxx> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> thanks to both of you for fixing my code! Regards Martin