Hi Shimoda-san,
Thanks for the feedback
> Subject: RE: [PATCH] usb: renesas_usbhs: Add a compatible string for
> r8a774a1
>
> Hi Biju-san,
>
> Thank you for the patch!
>
> > From: Biju Das, Sent: Friday, August 24, 2018 7:09 PM
> >
> > This patch adds support for r8a774a1 (RZ/G2M).
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > ---
> > drivers/usb/renesas_usbhs/common.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/renesas_usbhs/common.c
> > b/drivers/usb/renesas_usbhs/common.c
> > index 4310df4..f1a1694 100644
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct
> platform_device *pdev)
> > */
> > static const struct of_device_id usbhs_of_match[] = {
> > {
> > +.compatible = "renesas,usbhs-r8a774a1",
> > +.data = (void *)USBHS_TYPE_RCAR_GEN3,
> > +},
> > +{
>
> I don't think you need this adding entry for r8a774a1 actually because you
> also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs" for
> RZ/G2.
I agree. It is not needed, since fallback is present in the driver. Somehow I missed this.
> [1]
> https://patchwork.kernel.org/patch/10574875/
>
> Best regards,
> Yoshihiro Shimoda
>
> > .compatible = "renesas,usbhs-r8a7790",
> > .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > },
> > --
> > 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
