Re: [PATCH 3/4] usb: dwc3: trace: log ep commands in hex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

On Monday, 20 August 2018 15:06:31 EEST Andy Shevchenko wrote:
> On Mon, Aug 20, 2018 at 2:25 PM, Laurent Pinchart wrote:
> >> -     TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x --> status: %s",
> >> +     TP_printk("%s: cmd '%s' [%x] params %08x %08x %08x --> status: %s",
> > 
> > How about 0x%x ?
> 
> Side note: # is one character less for the same.

Doesn't that print 0 instead of 0x0 ? There's no ambiguity with 0, but I find 
that always printing the 0x is more consistent. I'll leave that up to Felipe, 
I'm OK with both options.

-- 
Regards,

Laurent Pinchart






[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux