On Sun, Aug 12, 2018 at 11:26:54PM +0100, Tom Todd wrote: > On, Sun, 12 Aug 2018 11:34:59 -0700 Joe Perches wrote: > >On Sun, 2018-08-12 at 19:06 +0100, Tom Todd wrote: > >> Fixed a code styling issue > >while it's OK to fix style only issues, it's much better > >to reorganize the code for reader clarity. > > Ok, thank you, I've taken your suggestions and created the a new version > > Restructured method proc_ioctl for readability and fixed code style > errors. Please always be very specific as to exactly what code style issues you are fixing. And never do more than one type of fix at a time, otherwise it is hard to review, and you can cause errors to be added, like you did here :( Please do not start working on code cleanups in any other area of the kernel other than drivers/staging/ as that is what that is for. To do so in other areas of the kernel causes more work for maintainers. thanks, greg k-h
