On Thu, 9 Aug 2018, Vladimir Zapolskiy wrote: > Instead of explicit setting of USB_STORAGE dependency for every > underlying build entries, exploit if USB_STORAGE / endif block. > > Signed-off-by: Vladimir Zapolskiy <vz@xxxxxxxxx> I think this is a worthwhile cleanup, although to make Greg happy you should mention in the description that this shortens the Kconfig file, making it easier to read and less error-prone, with no changes in behavior. > @@ -188,7 +177,6 @@ config USB_STORAGE_CYPRESS_ATACB > config USB_STORAGE_ENE_UB6250 > tristate "USB ENE card reader support" > depends on SCSI > - depends on USB_STORAGE You can also remove the "depends on SCSI" line here, since USB_STORAGE already depends on SCSI. > @@ -202,7 +190,7 @@ config USB_STORAGE_ENE_UB6250 > > config USB_UAS > tristate "USB Attached SCSI" > - depends on SCSI && USB_STORAGE > + depends on SCSI > help > The USB Attached SCSI protocol is supported by some USB > storage devices. It permits higher performance by supporting As Oliver points out, uas is significantly different from all the other entries in this file. They are sub-drivers for usb-storage, whereas uas is an almost totally separate driver. Yes, it does depend on usb-storage now, but that's subject to change in the future since the overlap between the two drivers is quite small. Just put the UAS portion outside the new conditional region and keep its explicit dependencies. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
