Re: [PATCH 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Do, 2018-08-09 at 10:50 +0300, Vladimir Zapolskiy wrote:
> Hi Oliver,
> 
> On 08/09/2018 10:38 AM, Oliver Neukum wrote:
> > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
> > > Because USB_STORAGE build symbol strictly depends on SCSI build
> > > symbol, there is no need to specify it again for USB_UAS and
> > > USB_STORAGE_ENE_UB6250 build options.
> > 
> > [..]
> > 
> > >  config USB_UAS
> > >  	tristate "USB Attached SCSI"
> > > -	depends on SCSI
> > >  	help
> > >  	  The USB Attached SCSI protocol is supported by some USB
> > >  	  storage devices.  It permits higher performance by supporting
> > 
> > Hi,
> > 
> > I am sorry, but this is wrong. You can build and use UAS without
> 
> can you please elaborate what is wrong exactly.
> 
> The change is non-functional.

Hi,

as far as I can tell you are introducing an implicit dependency
of CONFIG_USB_UAS on CONFIG_USB_STORAGE.
Now, firstly implicit references are bad anyway, secondly
in this case it is wrong. Uas works without usb-storage.

	Regards
		Oliver


	
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux