On 8/2/2018 12:46 AM, Felipe Balbi wrote:
> Hi,
>
> Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> writes:
>
> <snip>
>
>>> These patches will not fix the issue.
>>>
>> What do you think of this fix?
>>
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index f452ab708ffc..338f7ab8a8b4 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -2277,8 +2277,10 @@ static int
>> dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep,
>> * with one TRB pending in the ring. We need to manually clear
>> HWO bit
>> * from that TRB.
>> */
>> - if ((req->zero || req->unaligned) && (trb->ctrl & DWC3_TRB_CTRL_HWO)) {
>> - trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
>> + if ((req->zero || req->unaligned) && !chain) {
>> + if (trb->ctrl & DWC3_TRB_CTRL_HWO)
>> + trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
>> +
>> return 1;
>> }
> This is a rathher minimal fix. I like it. So this together with the one
> I wrote for the TRB type, right? Can you send this one as a proper patch
> and add the correct Cc stable and Fixes tags?
>
Yes. Can you create an official patch for that TRB type issue you found?
Thanks,
Thinh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
