Re: [PATCH v7] usb: gadget: uvc: configfs: Add bFrameIndex attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> writes:

> Hi Felipe,
>
> On Thursday, 26 July 2018 13:49:07 EEST Felipe Balbi wrote:
>> Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> writes:
>> > From: Joel Pepper <joel.pepper@xxxxxxxxxxxxxx>
>> > 
>> > - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size.
>> > - Automatically assign ascending bFrameIndex to each frame in a format.
>> > 
>> > Before all "bFrameindex" attributes were set to "1" with no way to
>> > configure the gadget otherwise. This resulted in the host always
>> > negotiating for bFrameIndex 1 (i.e. the first framesize of the gadget).
>> > After the negotiation the host driver will set the user or application
>> > selected framesize, while the gadget is actually set to the first
>> > framesize.
>> > 
>> > Now, when the containing format is linked into the streaming header,
>> > iterate over all child frame descriptors and assign ascending indices.
>> > The automatically assigned indices can be read from the new read only
>> > bFrameIndex configsfs attribute in each frame descriptor item.
>> > 
>> > Signed-off-by: Joel Pepper <joel.pepper@xxxxxxxxxxxxxx>
>> > [Simplified documentation, renamed function, blank space update]
>> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>> 
>> please rebase on testing/next, but give me a couple hours to go through
>> the rest of my inbox first ;)
>
> I will. Have you had time to go through the rest of your inbox now ? It's been 
> a few hours already I suppose :-)

well, pull request was already pushed to Greg. We're already in -rc7,
too late for this merge window.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux