On 7/26/2018 16:10, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyan <Grigor.Tovmasyan@xxxxxxxxxxxx> writes: >>>> Added hsotg argument to dwc2_readl/writel function prototype, >>>> and also instead of address pass offset of register. >>>> hsotg will contain flag field for endianness. >>>> >>>> Also customized dwc2_set_bit and dwc2_clear_bit function for >>>> dwc2_readl/writel functions. >>>> >>>> Signed-off-by: Gevorg Sahakyan <sahakyan@xxxxxxxxxxxx> >>> >>> sorry for the delay. I've been super busy with an internal task. >>> >>> Anyway, this doesn't apply to testing/next. Give me a couple hours for >>> me to go through the other patches, then I'll push testing/next so you >>> can rebase. >>> >>> checking file drivers/usb/dwc2/core.c >>> checking file drivers/usb/dwc2/core.h >>> Hunk #1 succeeded at 1172 (offset 3 lines). >>> Hunk #2 succeeded at 1184 (offset 3 lines). >>> Hunk #3 succeeded at 1195 (offset 3 lines). >>> Hunk #4 succeeded at 1321 (offset 3 lines). >>> checking file drivers/usb/dwc2/core_intr.c >>> checking file drivers/usb/dwc2/debugfs.c >>> checking file drivers/usb/dwc2/gadget.c >>> Hunk #11 succeeded at 916 (offset 6 lines). >>> Hunk #12 succeeded at 968 (offset 6 lines). >>> Hunk #13 succeeded at 1065 (offset 6 lines). >>> Hunk #14 succeeded at 1079 (offset 6 lines). >>> Hunk #15 succeeded at 1105 (offset 6 lines). >>> Hunk #16 succeeded at 1128 (offset 6 lines). >>> Hunk #17 succeeded at 1467 (offset 6 lines). >>> Hunk #18 succeeded at 1481 (offset 6 lines). >>> Hunk #19 succeeded at 1635 (offset 6 lines). >>> Hunk #20 succeeded at 1774 (offset 6 lines). >>> Hunk #21 succeeded at 1826 (offset 6 lines). >>> Hunk #22 succeeded at 1956 (offset 6 lines). >>> Hunk #23 succeeded at 2125 (offset 6 lines). >>> Hunk #24 succeeded at 2139 (offset 6 lines). >>> Hunk #25 succeeded at 2169 (offset 6 lines). >>> Hunk #26 succeeded at 2199 (offset 6 lines). >>> Hunk #27 succeeded at 2248 (offset 6 lines). >>> Hunk #28 succeeded at 2344 (offset 6 lines). >>> Hunk #29 succeeded at 2375 (offset 6 lines). >>> Hunk #30 succeeded at 2393 (offset 6 lines). >>> Hunk #31 succeeded at 2447 (offset 6 lines). >>> Hunk #32 succeeded at 2472 (offset 6 lines). >>> Hunk #33 succeeded at 2496 (offset 6 lines). >>> Hunk #34 succeeded at 2550 (offset 6 lines). >>> Hunk #35 succeeded at 2654 (offset 6 lines). >>> Hunk #36 succeeded at 2684 (offset 6 lines). >>> Hunk #37 succeeded at 2699 (offset 6 lines). >>> Hunk #38 succeeded at 2775 (offset 4 lines). >>> Hunk #39 succeeded at 2829 (offset 1 line). >>> Hunk #40 succeeded at 2866 (offset 1 line). >>> Hunk #41 succeeded at 2897 (offset 1 line). >>> Hunk #42 succeeded at 3016 (offset 1 line). >>> Hunk #43 succeeded at 3087 (offset 1 line). >>> Hunk #44 succeeded at 3115 (offset 1 line). >>> Hunk #45 succeeded at 3216 (offset 1 line). >>> Hunk #46 succeeded at 3231 (offset 1 line). >>> Hunk #47 succeeded at 3257 (offset 1 line). >>> Hunk #48 succeeded at 3277 (offset 1 line). >>> Hunk #49 succeeded at 3301 (offset 1 line). >>> Hunk #50 succeeded at 3345 (offset 1 line). >>> Hunk #51 succeeded at 3358 (offset 1 line). >>> Hunk #52 succeeded at 3387 (offset 1 line). >>> Hunk #53 succeeded at 3425 (offset 1 line). >>> Hunk #54 succeeded at 3433 (offset 1 line). >>> Hunk #55 succeeded at 3470 (offset 1 line). >>> Hunk #56 succeeded at 3479 (offset 1 line). >>> Hunk #57 succeeded at 3516 (offset 1 line). >>> Hunk #58 succeeded at 3527 (offset 1 line). >>> Hunk #59 succeeded at 3537 (offset 1 line). >>> Hunk #60 succeeded at 3623 (offset 1 line). >>> Hunk #61 succeeded at 3639 (offset 1 line). >>> Hunk #62 succeeded at 3653 (offset 1 line). >>> Hunk #63 succeeded at 3668 (offset 1 line). >>> Hunk #64 succeeded at 3708 (offset 1 line). >>> Hunk #65 succeeded at 3716 (offset 1 line). >>> Hunk #66 succeeded at 3725 (offset 1 line). >>> Hunk #67 succeeded at 3736 (offset 1 line). >>> Hunk #68 succeeded at 3744 (offset 1 line). >>> Hunk #69 succeeded at 3759 (offset 1 line). >>> Hunk #70 succeeded at 3831 (offset 1 line). >>> Hunk #71 succeeded at 3879 (offset 1 line). >>> Hunk #72 succeeded at 3920 (offset 1 line). >>> Hunk #73 succeeded at 3958 (offset 1 line). >>> Hunk #74 succeeded at 3970 (offset 1 line). >>> Hunk #75 succeeded at 4021 (offset 1 line). >>> Hunk #76 succeeded at 4031 (offset 1 line). >>> Hunk #77 succeeded at 4138 (offset 1 line). >>> Hunk #78 succeeded at 4151 (offset 1 line). >>> Hunk #79 succeeded at 4165 (offset 1 line). >>> Hunk #80 succeeded at 4213 (offset 1 line). >>> Hunk #81 succeeded at 4243 (offset 1 line). >>> Hunk #82 succeeded at 4536 (offset 1 line). >>> Hunk #83 succeeded at 4607 (offset 1 line). >>> Hunk #84 succeeded at 4632 (offset 1 line). >>> Hunk #85 succeeded at 4834 (offset 4 lines). >>> Hunk #86 succeeded at 4850 (offset 4 lines). >>> Hunk #87 succeeded at 4862 (offset 4 lines). >>> Hunk #88 succeeded at 4897 (offset 4 lines). >>> Hunk #89 succeeded at 4916 (offset 4 lines). >>> Hunk #90 succeeded at 4928 (offset 4 lines). >>> Hunk #91 succeeded at 4953 (offset 4 lines). >>> Hunk #92 succeeded at 4987 (offset 4 lines). >>> Hunk #93 succeeded at 5062 (offset 4 lines). >>> Hunk #94 succeeded at 5121 (offset 4 lines). >>> checking file drivers/usb/dwc2/hcd.c >>> Hunk #40 FAILED at 1566. >>> Hunk #41 succeeded at 1584 (offset 9 lines). >>> Hunk #42 succeeded at 1609 (offset 9 lines). >>> Hunk #43 succeeded at 1667 (offset 9 lines). >>> Hunk #44 succeeded at 1697 (offset 9 lines). >>> Hunk #45 succeeded at 1754 (offset 9 lines). >>> Hunk #46 succeeded at 1762 (offset 9 lines). >>> Hunk #47 succeeded at 1772 (offset 9 lines). >>> Hunk #48 succeeded at 1886 (offset 9 lines). >>> Hunk #49 succeeded at 1907 (offset 9 lines). >>> Hunk #50 succeeded at 1920 (offset 9 lines). >>> Hunk #51 succeeded at 1984 (offset 9 lines). >>> Hunk #52 succeeded at 1998 (offset 9 lines). >>> Hunk #53 succeeded at 2026 (offset 9 lines). >>> Hunk #54 succeeded at 2070 (offset 9 lines). >>> Hunk #55 succeeded at 2094 (offset 9 lines). >>> Hunk #56 succeeded at 2113 (offset 9 lines). >>> Hunk #57 succeeded at 2278 (offset 9 lines). >>> Hunk #58 succeeded at 2290 (offset 9 lines). >>> Hunk #59 succeeded at 2324 (offset 9 lines). >>> Hunk #60 succeeded at 2373 (offset 9 lines). >>> Hunk #61 succeeded at 2395 (offset 9 lines). >>> Hunk #62 succeeded at 2414 (offset 9 lines). >>> Hunk #63 succeeded at 2425 (offset 9 lines). >>> Hunk #64 succeeded at 2445 (offset 9 lines). >>> Hunk #65 succeeded at 2481 (offset 9 lines). >>> Hunk #66 succeeded at 3075 (offset 64 lines). >>> Hunk #67 succeeded at 3090 (offset 64 lines). >>> Hunk #68 succeeded at 3160 (offset 64 lines). >>> Hunk #69 succeeded at 3173 (offset 64 lines). >>> Hunk #70 succeeded at 3205 (offset 64 lines). >>> Hunk #71 succeeded at 3228 (offset 64 lines). >>> Hunk #72 succeeded at 3265 (offset 64 lines). >>> Hunk #73 succeeded at 3285 (offset 64 lines). >>> Hunk #74 succeeded at 3296 (offset 64 lines). >>> Hunk #75 succeeded at 3335 (offset 64 lines). >>> Hunk #76 succeeded at 3353 (offset 64 lines). >>> Hunk #77 succeeded at 3379 (offset 64 lines). >>> Hunk #78 succeeded at 3439 (offset 64 lines). >>> Hunk #79 succeeded at 3470 (offset 64 lines). >>> Hunk #80 succeeded at 3488 (offset 64 lines). >>> Hunk #81 succeeded at 3522 (offset 64 lines). >>> Hunk #82 succeeded at 3533 (offset 64 lines). >>> Hunk #83 succeeded at 3541 (offset 64 lines). >>> Hunk #84 succeeded at 3585 (offset 64 lines). >>> Hunk #85 succeeded at 3605 (offset 64 lines). >>> Hunk #86 succeeded at 3726 (offset 64 lines). >>> Hunk #87 succeeded at 3767 (offset 64 lines). >>> Hunk #88 succeeded at 3816 (offset 64 lines). >>> Hunk #89 succeeded at 3826 (offset 64 lines). >>> Hunk #90 succeeded at 3845 (offset 64 lines). >>> Hunk #91 succeeded at 3867 (offset 64 lines). >>> Hunk #92 succeeded at 3924 (offset 64 lines). >>> Hunk #93 succeeded at 3935 (offset 64 lines). >>> Hunk #94 succeeded at 4056 (offset 64 lines). >>> Hunk #95 succeeded at 4108 (offset 64 lines). >>> Hunk #96 succeeded at 4363 (offset 64 lines). >>> Hunk #97 succeeded at 4473 (offset 64 lines). >>> Hunk #98 succeeded at 4564 (offset 64 lines). >>> Hunk #99 succeeded at 5085 (offset 64 lines). >>> Hunk #100 succeeded at 5138 (offset 64 lines). >>> Hunk #101 succeeded at 5428 (offset 80 lines). >>> Hunk #102 succeeded at 5464 (offset 80 lines). >>> Hunk #103 succeeded at 5507 with fuzz 1 (offset 80 lines). >>> Hunk #104 succeeded at 5523 (offset 80 lines). >>> Hunk #105 succeeded at 5620 (offset 80 lines). >>> Hunk #106 succeeded at 5651 (offset 80 lines). >>> 1 out of 106 hunks FAILED >>> checking file drivers/usb/dwc2/hcd.h >>> Hunk #1 succeeded at 469 (offset 8 lines). >>> Hunk #2 succeeded at 487 (offset 8 lines). >>> Hunk #3 succeeded at 690 (offset 8 lines). >>> checking file drivers/usb/dwc2/hcd_ddma.c >>> checking file drivers/usb/dwc2/hcd_intr.c >>> Hunk #20 succeeded at 959 (offset 7 lines). >>> Hunk #21 succeeded at 1185 (offset 7 lines). >>> Hunk #22 succeeded at 1561 (offset 7 lines). >>> Hunk #23 succeeded at 1776 (offset 7 lines). >>> Hunk #24 succeeded at 1803 (offset 7 lines). >>> Hunk #25 succeeded at 1863 (offset 7 lines). >>> Hunk #26 succeeded at 1958 (offset 7 lines). >>> Hunk #27 succeeded at 2031 (offset 7 lines). >>> Hunk #28 succeeded at 2047 (offset 7 lines). >>> Hunk #29 succeeded at 2182 (offset 7 lines). >>> Hunk #30 succeeded at 2266 (offset 7 lines). >>> checking file drivers/usb/dwc2/hcd_queue.c >>> Hunk #2 succeeded at 1747 (offset 3 lines). >>> Hunk #3 succeeded at 1788 (offset 3 lines). >>> checking file drivers/usb/dwc2/params.c >>> >> >> This patch series is very massive and touches almost every file in dwc2 >> driver that's why it's always causes some problem. >> >> This patch series also is very important. So to avoid multiply re-basing >> please do following instructions. >> >> 1. Please let us know when you will finish with other patches. >> 2. After that please do not add other patches related with dwc2 >> 'till Gevorg will not send you re-based version. >> 3. Apply it as soon as possible. > > I'm done. Please don't take long to rebase, we're already in -rc6 and I > want to send Greg a pull request early next week. Gevorg just re-sent re-based versions of patches: [PATCH v2 1/3] usb: dwc2: Modify dwc2_readl/writel functions prototype [PATCH v2 2/3] usb: dwc2: replace ioread32/iowrite32_rep with dwc2_readl/writel_rep [PATCH v2 3/3] usb: dwc2: Make dwc2_readl/writel functions endianness-agnostic. Please apply them on top of e7e1e9cff040 commit. > >> Thanks for your understanding and sorry for inconvenience. > > no problem > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
