Hi Andy, Thanks for your review comments, please find my comments inline >-----Original Message----- >From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] >Sent: Wednesday, July 25, 2018 8:36 PM >To: Anurag Kumar Vulisha <anuragku@xxxxxxxxxx> >Cc: Felipe Balbi <balbi@xxxxxxxxxx>; Greg Kroah-Hartman ><gregkh@xxxxxxxxxxxxxxxxxxx>; v.anuragkumar@xxxxxxxxx; USB <linux- >usb@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> >Subject: Re: [PATCH 4/8] usb: dwc3: implement stream transfer timeout > >On Wed, Jul 25, 2018 at 2:51 PM, Anurag Kumar Vulisha ><anurag.kumar.vulisha@xxxxxxxxxx> wrote: >> According to dwc3 databook when streams are used, it may be possible >> for the host and device become out of sync, where device may wait for >> host to issue prime transcation and host may wait for device to issue >> erdy. To avoid such deadlock, timeout needs to be implemented. After >> timeout occurs, device will first stop transfer and restart the >> transfer again. This patch does the same. > >> +/* >> + * Timeout value in msecs used by stream_timeout_timer when streams >> +are enabled */ >> +#define STREAM_TIMEOUT 50 > >Perhaps, STREAM_TIMEOUT_MS 50 > >Dunno about this driver, but it's a usual practice to help reader with understanding >code on the first glance. > Since I have mentioned "msecs" in comment above describing the STREAM_TIMEOUT, thought it would suffice. But if you feel I should change it, I will fix it in v2 Thanks, Anurag Kumar Vulisha >-- >With Best Regards, >Andy Shevchenko ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
