On Di, 2018-07-24 at 15:36 -0700, Patong Yang wrote: > +static int xrusb_ctrl_msg(struct xrusb *xrusb, > + int request, int value, void *buf, int len) > +{ > + int rv = usb_control_msg(xrusb->dev, > + usb_sndctrlpipe(xrusb->dev, 0), > + request, > + USB_RT_XRUSB, > + value, > + xrusb->control->altsetting[0].desc.bInterfaceNumber, > + buf, > + len, > + 5000); Please use the symbolic constant. > + return rv < 0 ? rv : 0; > +} Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html