Re: [PATCH v3 02/23] usb: usbtmc: Add ioctl for generic requests on control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 24, 2018 at 11:05:29AM +0200, Guido Kiener wrote:
> +struct usbtmc_ctrlrequest {
> +	struct usbtmc_request req;
> +	__u64 data; /* pointer to user space */
> +} __attribute__ ((packed));

Hint, this structure could just be:
	struct usbtmc_ctrlreqest {
		struct usbtmc_request req;
		__u8 data[0];
	} __attribute__((__aligned__(8)));

No more pointer mess anymore, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux