On Fri, Jul 20, 2018 at 04:22:17PM +0100, Martyn Welch wrote: > On Fri, 2018-07-20 at 12:35 +0000, Karoly Pados wrote: > > This patch adds GPIO support for CP2102N devices. > > > > It introduces new generic code to support emulating separate > > input and outputs directions even though these devices > > only know output modes (open-drain and pushpull). Existing > > GPIO support for CP2105 has been migrated over to the new > > code structure. > > > > Only limitation is that for the QFN28 variant, only 4 out of > > 7 GPIOs are supported. This is because the config array > > locations of the last 3 pins are not documented, and reverse > > engineering revealed offsets that conflicted with other > > documented functions. Hence we'll play it safe instead > > until somebody clears this up further. > > > > Signed-off-by: Karoly Pados <pados@xxxxxxxx> Thanks for the updated commit message, looks goods now. > As Johan made some changes, I think his Signed-off-by should be here > as is in v3. Right. I actually just replaced the commit message in v3 which had a note about what I had changed. > Other than that: > > Acked-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxxxx> Thanks for the ack. And again, thanks to both of you for getting this useful functionality in place. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html