On Thu, Jul 19, 2018 at 01:55:12AM +0800, m13297920107@xxxxxxx wrote:
> From 14bd57ea5c5fc385bd36b5a3ea5c805337bbc8db Mon Sep 17 00:00:00 2001
> From: Movie Song <MovieSong@xxxxxxxxxxxxx>
> Date: Thu, 19 Jul 2018 02:20:48 +0800
> Subject: [PATCH] USB:serial:pl2303:add a new device id for ATEN
Add spaces after the colons (':') in the Subject above, and place a
short commit message here before your SoB.
> Signed-off-by:MovieSong<MovieSong@xxxxxxxxxxxxx>
Missing spaces in you SoB as well.
> ---
> drivers/usb/serial/pl2303.c | 2 ++
> drivers/usb/serial/pl2303.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index 5d1a193..e41f725 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -52,6 +52,8 @@
> .driver_info = PL2303_QUIRK_ENDPOINT_HACK },
> { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_UC485),
> .driver_info = PL2303_QUIRK_ENDPOINT_HACK },
> + { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_UC232B),
> + .driver_info = PL2303_QUIRK_ENDPOINT_HACK },
> { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_ID2) },
> { USB_DEVICE(ATEN_VENDOR_ID2, ATEN_PRODUCT_ID) },
> { USB_DEVICE(ELCOM_VENDOR_ID, ELCOM_PRODUCT_ID) },
> diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
> index fcd7239..26965cc 100644
> --- a/drivers/usb/serial/pl2303.h
> +++ b/drivers/usb/serial/pl2303.h
> @@ -24,6 +24,7 @@
> #define ATEN_VENDOR_ID2 0x0547
> #define ATEN_PRODUCT_ID 0x2008
> #define ATEN_PRODUCT_UC485 0x2021
> +#define ATEN_PRODUCT_UC232B 0x2022
> #define ATEN_PRODUCT_ID2 0x2118
>
> #define IODATA_VENDOR_ID 0x04bb
As I suggested earlier, try sending the patch to yourself first and run
scripts/checkpatch.pl on it. The patch is still whitespace corrupted
(probably by your mail client) as checkpatch would have let you know:
WARNING: Use a single space after Signed-off-by:
#13:
Signed-off-by:MovieSong<MovieSong@xxxxxxxxxxxxx>
WARNING: email address 'MovieSong<MovieSong@xxxxxxxxxxxxx>' might be better as 'MovieSong <MovieSong@xxxxxxxxxxxxx>'
#13:
Signed-off-by:MovieSong<MovieSong@xxxxxxxxxxxxx>
WARNING: please, no spaces at the start of a line
#27: FILE: drivers/usb/serial/pl2303.c:55:
+ { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_UC232B),$
WARNING: please, no spaces at the start of a line
#28: FILE: drivers/usb/serial/pl2303.c:56:
+ .driver_info = PL2303_QUIRK_ENDPOINT_HACK },$
total: 1 errors, 4 warnings, 15 lines checked
git-send-email is convenient for sending patches (e.g. generated with
git-format-patch). Perhaps you can set that up.
One more try?
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
