On Fri, Jul 13, 2018 at 12:35:27AM +0200, Sebastian Andrzej Siewior wrote: > Provide usb_fill_iso_urb() for the initialisation of isochronous URBs. > We already have one of this helpers for control, bulk and interruptible > URB types. This helps to keep the initialisation of the URB members in > one place. > Update the documentation by adding this to the available init functions > and remove the suggestion to use the `_int_' helper which might provide > wrong encoding for the `interval' member. > > This looks like it would cover most users nicely. The sound subsystem > initialises the ->iso_frame_desc[].offset + length member (often) at a > different location and I'm not sure ->interval will work always as > expected. So we might need to overwrite those two in worst case. > > Some users also initialise ->iso_frame_desc[].actual_length but I don't > this is required since it is the return value. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > --- > Documentation/driver-api/usb/URB.rst | 12 +++---- > include/linux/usb.h | 53 ++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+), 6 deletions(-) Do you have a few example patches of using this new function? Many many years ago we tried to create this function, but we gave up as it just didn't seem to work for the majority of the users of ISO packets. Maybe things have changed since then and people do it all more in a "standard" way and we can take advantage of this. But it would be nice to see proof it can be used before taking this patch. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
