Hello Ruslan,
On Tue, Jul 03, 2018 at 01:36:17AM +0300, Ruslan Bilovol wrote:
> On Tue, Jul 3, 2018 at 12:46 AM, Eugeniu Rosca <roscaeugeniu@xxxxxxxxx> wrote:
> > The list [1] of commits doing endianness fixes in USB subsystem is long
> > due to below quote from USB spec Revision 2.0 from April 27, 2000:
> >
> > ------------
> > 8.1 Byte/Bit Ordering
> >
> > Multiple byte fields in standard descriptors, requests, and responses
> > are interpreted as and moved over the bus in little-endian order, i.e.
> > LSB to MSB.
> > ------------
> >
> > This commit belongs to the same family.
> >
> > [1] Example of endianness fixes in USB subsystem:
> > commit 14e1d56cbea6 ("usb: gadget: f_uac2: endianness fixes.")
> > commit 42370b821168 ("usb: gadget: f_uac1: endianness fixes.")
> > commit 63afd5cc7877 ("USB: chaoskey: fix Alea quirk on big-endian hosts")
> > commit 74098c4ac782 ("usb: gadget: acm: fix endianness in notifications")
> > commit cdd7928df0d2 ("ACM gadget: fix endianness in notifications")
> > commit 323ece54e076 ("cdc-wdm: fix endianness bug in debug statements")
> > commit e102609f1072 ("usb: gadget: uvc: Fix endianness mismatches")
> > list goes on
> >
> > Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver")
> > Signed-off-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>
>
> Good catch!
>
> Reviewed-by: Ruslan Bilovol <ruslan.bilovol@xxxxxxxxx>
Thanks for the review. FWIW, I've accidentally noticed post-push that
a similar fix has been incorporated by you in the UAC3 implementation
from https://lkml.org/lkml/2017/11/6/1514 ("[PATCH 1/1] usb: gadget: add
USB Audio Device Class 3.0 gadget support").
Best regards,
Eugeniu.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
