> On Tue, Jul 03, 2018 at 08:57:45PM +0100, Pawel Laszczak wrote: > > From: Laszczak Pawel <pawell.cadence.com> > > > > Signed-off-by: Laszczak Pawel <pawell@xxxxxxxxxxx> > > --- > > I can't take patches without any changelog text at all, sorry. > > Also, your subject lines need work, look at how all other usb patches are > written, your long prefix is not really helping out here. > > > drivers/usb/usbssp/gadget.c | 2082 > > +++++++++++++++++++++++++++++++++++ > > 1 file changed, 2082 insertions(+) > > create mode 100644 drivers/usb/usbssp/gadget.c > > > Just splitting the driver up by file is hard to review, as you are just dumping > individual files on us, not functionality, and we can not review anything until > all of them are added. Can you break this up into logical chunks? Make > these in a way that is easy to review, would you want to review this patch > series in this way? It's quite large driver and I thought that this form will be better and faster to review. I didn't want to prepare too much patches. I will prepare new patch set and I will tray to split it into logical chunk. Thanks, Pawel Laszczak -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
