On Tue, Jul 03, 2018 at 07:52:07AM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > > > We can have the options in defconfig, but they can still be turned off > > for whatever reason and we get the hang. Really, missing a user > > selectable option in defconfig shouldn't result in a system hang. > > Yes, 100% agree and this is exactly what this USB patch is all about :-) > > The whole point of this USB patch is not to let the the system to hang > when the defconfig options are turned off. > > It will warn the user that CONFIG_USB_CHIPIDEA_ULPI needs to be > selected, will propagate an error, but at least the system will not > hang. > > The user will certainly notice the big warning which says "Select > CONFIG_USB_CHIPIDEA_ULPI in order to use ULPI mode" > > Please check the original patch of this thread: > https://patchwork.kernel.org/patch/10486371/ I'm still not convinced this is the best way to go. But that's USB maintainer's call. I will just apply defconfig patches which shouldn't hurt anyway. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
