On 2018-06-20 21:50:49 [+0100], Sean Young wrote: > On Wed, Jun 20, 2018 at 01:01:00PM +0200, Sebastian Andrzej Siewior wrote: > > Using usb_fill_int_urb() helps to find code which initializes an > > URB. A grep for members of the struct (like ->complete) reveal lots > > of other things, too. > > The reason I didn't use usb_fill_int_urb() is that is not an interrupt > urb, it's a iso urb. I'm not sure what affect the interval handling > in usb_fill_int_urb() will have on this. It is wrong, I had false memory on regarding ISO/FS. There will be a respin a of the usb_fill* patches once we have usb_fill_iso_urb(). Mauro, could you please consider only the !fill patches from the series: [PATCH 04/27] media: cx231xx: use irqsave() in USB's complete callback [PATCH 07/27] media: em28xx-audio: use GFP_KERNEL for memory allocation during init [PATCH 08/27] media: em28xx-audio: use irqsave() in USB's complete callback [PATCH 10/27] media: go7007: use irqsave() in USB's complete callback [PATCH 14/27] media: gspca: sq930x: use GFP_KERNEL in sd_dq_callback() [PATCH 19/27] media: tm6000: use irqsave() in USB's complete callback [PATCH 23/27] media: usbtv: use irqsave() in USB's complete callback [PATCH 25/27] media: usbvision: remove time_in_irq > Sean Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html