Re: [PATCH 3/3] usb: gadget: storage: Remove EXPORT_SYMBOL_GPL for kref_{put, get}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 06/14/2018 12:23 PM, Jaejoong Kim wrote:

> Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used

   I thought you removed the exports from the real kref_{get|put}(). :-)
Your patch subject and description are simply misleading the way they are
written.

> only in f_mass_storage
> 
> Signed-off-by: Jaejoong Kim <climbbb.kim@xxxxxxxxx>
> ---
>  drivers/usb/gadget/function/f_mass_storage.c | 6 ++----
>  drivers/usb/gadget/function/f_mass_storage.h | 4 ----
>  2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index b6e2930..ba0eb7e 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -2558,17 +2558,15 @@ static void fsg_lun_release(struct device *dev)
>  	/* Nothing needs to be done */
>  }
>  
> -void fsg_common_get(struct fsg_common *common)
> +static void __maybe_unused fsg_common_get(struct fsg_common *common)
>  {
>  	kref_get(&common->ref);
>  }
> -EXPORT_SYMBOL_GPL(fsg_common_get);
>  
> -void fsg_common_put(struct fsg_common *common)
> +static void fsg_common_put(struct fsg_common *common)
>  {
>  	kref_put(&common->ref, fsg_common_release);
>  }
> -EXPORT_SYMBOL_GPL(fsg_common_put);
>  
>  static struct fsg_common *fsg_common_setup(struct fsg_common *common)
>  {
[...]

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux