On Thu, May 31, 2018 at 7:55 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: >> - donot rename err to ret - per Andy > > Hm... >> - int err, i; >> + err = match_string(usbphy_modes, ARRAY_SIZE(usbphy_modes), phy_type); >> + if (err < 0) > > This is one of the few cases when 'err' is not the best name for such a > variable. I'd prefer to see something like 'match' or even 'rc' or 'ret'... :-) Then leaving i would make it? I'm okay with either which just not renames err, b/c it's used with something else in this function. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
