Re: [PATCH] USB:serial:release port object after releasing serial

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 22, 2009 at 02:43:56PM -0400, Alan Stern wrote:
> On Wed, 22 Apr 2009, Greg KH wrote:
> 
> > On Thu, Apr 23, 2009 at 01:40:08AM +0800, tom.leiming@xxxxxxxxx wrote:
> > > From: Ming Lei <tom.leiming@xxxxxxxxx>
> > > 
> > > This patch releases the usb_serial_port object after releasing
> > > usb_serial object, because .shutdown of usb_serial_driver often
> > > references port object and it is called in destroy_serial(),
> > > when it is touched, port object has been released.
> > > 
> > > This bug is introduced by Alan's patch:
> > > 	usb-serial-fix-lifetime-and-locking-problems.patch.
> > > 
> > > The bug is reproduced very easily by the following steps:
> > > 1, plug a usb serial port and unplug it;
> > > or
> > > 2,plug a use serial port, open it ,disconnect it, and close it.
> > > 
> > > In each case, the oops will happen:
> > 
> > Ick.
> > 
> > Alan, care to take this patch, merge it with yours and then I can take
> > the new one?  I don't want to add a patch that is known broken to the
> > tree.
> 
> Yeah, I'll take a look at it.  Will anyone be able to test a new patch 
> (I don't have any USB serial devices)?

Yes, I have a few dozen here :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux