On Wed, May 30, 2018 at 08:20:50PM +0200, Alexandre Belloni wrote: > On 29/05/2018 17:31:02+0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > There is also no need to keep the file dentries around at all, so remove > > those variables from the device structure. > > > > Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> > > Cc: Felipe Balbi <balbi@xxxxxxxxxx> > > Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> Thanks for reviewing this. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html