Re: [PATCH 02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Zitat von Oliver Neukum <oneukum@xxxxxxxx>:

Am Montag, den 21.05.2018, 21:00 +0000 schrieb guido@kiener-
muenchen.de:

I looked for a race here, but I do not find a race between open and release,
since a refcount of "file_data->data->kref" is always hold by
usbtmc_probe/disconnect.

However I see a race between usbtmc_open and usbtmc_disconnect. Are these
callback functions called mutual exclusive?

No, they are not.

In the meantime I found these conflictive hints:

https://github.com/torvalds/linux/commit/52a749992ca6a0fd304609af40ed3bfd6cef4660
and
https://elixir.bootlin.com/linux/v4.17-rc6/source/include/linux/usb.h#L1164

What do you think?
My current feeling is that open/disconnect is mutual exclusive.
We also could verify what really happens.

Thanks,

Guido


I'm not sure, but if not, then I think we have the same problem in
usb-skeleton.c

In usb-skeleton.c a race exists. You are right.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux