Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 18, 2018 at 03:02:10PM +0000, guido@xxxxxxxxxxxxxxxxxx wrote:
> 
> Zitat von Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> 
> > On Thu, May 17, 2018 at 07:03:31PM +0200, Guido Kiener wrote:
> > > @@ -2420,8 +2476,8 @@ static int usbtmc_probe(struct usb_interface *intf,
> > > 
> > >  	retcode = usb_register_dev(intf, &usbtmc_class);
> > >  	if (retcode) {
> > > -		dev_err(&intf->dev, "Not able to get a minor"
> > > -			" (base %u, slice default): %d\n", USBTMC_MINOR_BASE,
> > > +		dev_err(&intf->dev, "Not able to get a minor (base %u, slice
> > > default): %d\n",
> > > +			USBTMC_MINOR_BASE,
> > >  			retcode);
> > 
> > Nice change, but totally not relevant for this specific patch :(
> 
> Extra patch or just omit?

Extra patch please :)

> I thought kernel message must not be broken due to rule 80 characters per
> line.

You are correct, just don't try to "sneak" it into a patch that does
something totally different.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux