Re: [PATCH 1/4] USB: serial: ftdi_sio: fix IXON/IXOFF mixup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 18, 2018 at 03:53:54PM +0200, Greg Kroah-Hartman wrote:
> On Fri, May 18, 2018 at 03:25:47PM +0200, Johan Hovold wrote:
> > Since forever this driver has had IXON and IXOFF mixed up, and has used
> > the latter rather than the former to enable hardware-assisted software
> > flow control on output.

> Ugh, that's a huge sign that no one actually uses IXON/IXOFF anymore :(

Could be that some applications set both IXON and IXOFF "just to be
safe"; that appears to be the case with minicom at least.

> Anyway, thanks for fixing this up, should also probably be backported to
> the stable kernels.

I considered that, but since its a change in behaviour I figured it was
best that anyone affected hits this with a major (minor?) kernel version
update (rather than a stable update). But I'll add a stable tag if you
think it's warranted?

> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Thanks for the review.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux