Kumar Gala wrote: > > On Apr 21, 2009, at 2:03 PM, David Brownell wrote: > >> On Tuesday 21 April 2009, Subrata Modak wrote: >>> Observing this for the first time: >>> >>> CC drivers/usb/host/ohci-hcd.o >>> In file included from drivers/usb/host/ohci-hcd.c:1060: >>> drivers/usb/host/ohci-ppc-of.c:242:2: error: #error "No endianess >> >> Hmm, scripts/get_maintainer.pl doesn't report >> the PPC folk who maintain that file and its >> kbuild infrastructure. >> >> Can we have some PPC folk look at (and fix) this? > > The problem is in the drivers/usb/host/Kconfig: > > config USB_OHCI_HCD_PPC_OF_BE > bool "Support big endian HC" > depends on USB_OHCI_HCD_PPC_OF > default y > select USB_OHCI_BIG_ENDIAN_DESC > select USB_OHCI_BIG_ENDIAN_MMIO > > config USB_OHCI_HCD_PPC_OF_LE > bool "Support little endian HC" > depends on USB_OHCI_HCD_PPC_OF > default n > select USB_OHCI_LITTLE_ENDIAN > > Since its feasible to say 'n' to both we get the compile error. How do > we enforce having at least one set? Looks like using "choice" without "optional" would do it. See Documentation/kbuild/kconfig-language.txt and various examples in Kconfig* files. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
