Hi > -----Original Message----- > From: Mats Karrman [mailto:mats.dev.list@xxxxxxxxx] > Sent: 2018年5月12日 3:52 > To: Jun Li <jun.li@xxxxxxx>; robh+dt@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > heikki.krogerus@xxxxxxxxxxxxxxx; linux@xxxxxxxxxxxx > Cc: a.hajda@xxxxxxxxxxx; cw00.choi@xxxxxxxxxxx; > shufan_lee@xxxxxxxxxxx; Peter Chen <peter.chen@xxxxxxx>; > gsomlo@xxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH v5 03/14] staging: typec: tcpci: add compatible string for > nxp ptn5110 > > Hi Li Jun, > > On 2018-05-03 02:24, Li Jun wrote: > > > Add nxp ptn5110 typec controller compatible string: usb-tcpci,ptn5110, > > which is a standard tcpci chip with power delivery support. > > > > Signed-off-by: Li Jun <jun.li@xxxxxxx> > > --- > > drivers/staging/typec/tcpci.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/typec/tcpci.c > > b/drivers/staging/typec/tcpci.c index 076d97e..741a80a 100644 > > --- a/drivers/staging/typec/tcpci.c > > +++ b/drivers/staging/typec/tcpci.c > > @@ -576,6 +576,7 @@ MODULE_DEVICE_TABLE(i2c, tcpci_id); > > #ifdef CONFIG_OF > > static const struct of_device_id tcpci_of_match[] = { > > { .compatible = "usb,tcpci", }, > > Either this line should go away, or a "generic TCPCI controller" line should be > added to the DT documentation. This binding name didn't follow the rule "<vender prefix>, <chip specific>", AFAIK there is no user on upstream kernel, if no objection, I can remove it. Li Jun > > BR // Mats > > > + { .compatible = "nxp,ptn5110", }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, tcpci_of_match); > > ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
