Re: [PATCH v3 1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, den 07.05.2018, 08:31 -0500 schrieb  David R. Bild :
> > > +     spi_master->flags = 0;
> > > +     spi_master->setup = xapea00x_spi_setup;
> > > +     spi_master->transfer_one_message = xapea00x_spi_transfer_one_message;
> > > +
> > > +     retval = spi_register_master(spi_master);
> > > +
> > > +     if (retval)
> > > +             goto free_spi;
> > > +
> > > +     dev->spi_master = spi_master;
> > 
> > Race condition.
> > 
> 
> What race condition do you see?  (I appreciate the review, but need
> some more specific help here.)

Hi,

you have registered the master. So it is functional, but if any
callback goes for dev->spi_master at that point, it will read an
incorrect value.

	HTH
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux