Re: [PATCH] USB: serial: visor: handle potential invalid device configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 02, 2018 at 09:50:04AM +0200, Johan Hovold wrote:
> On Sun, Apr 29, 2018 at 05:41:55PM +0200, Greg Kroah-Hartman wrote:
> > If we get an invalid device configuration from a palm 3 type device, we
> > might incorrectly parse things, and we have the potential to crash in
> > "interesting" ways.
> > 
> > Fix this up by verifying the size of the configuration passed to us by
> > the device, and only if it is correct, will we handle it.
> > 
> > Reported-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
> > Reviewed-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > 
> > ---
> > 
> > Here is my long-forgotten patch for the visor driver to resolve an issue
> > that Andrey found back in September of 2017.  Sorry for the long delay.
> > 
> > Johan, I incorporated your review comments of my original one-off patch
> > here as well.
> 
> Thanks for the update. I've applied this for 4.17-rc now after adding a
> stable tag and a comment about this one also fixing a slab info leak
> (through that dev_info in the port loop below).

Ugh, I forgot about the stable tag, thanks for that!

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux